nvmet: use NVME_CMD_EFFECTS_CSUPP instead of open coding it

Use NVME_CMD_EFFECTS_CSUPP instead of open coding it and assign a
single value to multiple array entries instead of repeated assignments.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 53a004e..111a5cb 100644 (file)
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -164,26 +164,29 @@ out:
 
 static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log)
 {
-       log->acs[nvme_admin_get_log_page]       = cpu_to_le32(1 << 0);
-       log->acs[nvme_admin_identify]           = cpu_to_le32(1 << 0);
-       log->acs[nvme_admin_abort_cmd]          = cpu_to_le32(1 << 0);
-       log->acs[nvme_admin_set_features]       = cpu_to_le32(1 << 0);
-       log->acs[nvme_admin_get_features]       = cpu_to_le32(1 << 0);
-       log->acs[nvme_admin_async_event]        = cpu_to_le32(1 << 0);
-       log->acs[nvme_admin_keep_alive]         = cpu_to_le32(1 << 0);
-
-       log->iocs[nvme_cmd_read]                = cpu_to_le32(1 << 0);
-       log->iocs[nvme_cmd_write]               = cpu_to_le32(1 << 0);
-       log->iocs[nvme_cmd_flush]               = cpu_to_le32(1 << 0);
-       log->iocs[nvme_cmd_dsm]                 = cpu_to_le32(1 << 0);
-       log->iocs[nvme_cmd_write_zeroes]        = cpu_to_le32(1 << 0);
+       log->acs[nvme_admin_get_log_page] =
+       log->acs[nvme_admin_identify] =
+       log->acs[nvme_admin_abort_cmd] =
+       log->acs[nvme_admin_set_features] =
+       log->acs[nvme_admin_get_features] =
+       log->acs[nvme_admin_async_event] =
+       log->acs[nvme_admin_keep_alive] =
+               cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
+
+       log->iocs[nvme_cmd_read] =
+       log->iocs[nvme_cmd_write] =
+       log->iocs[nvme_cmd_flush] =
+       log->iocs[nvme_cmd_dsm] =
+       log->iocs[nvme_cmd_write_zeroes] =
+               cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
 }
 
 static void nvmet_get_cmd_effects_zns(struct nvme_effects_log *log)
 {
-       log->iocs[nvme_cmd_zone_append]         = cpu_to_le32(1 << 0);
-       log->iocs[nvme_cmd_zone_mgmt_send]      = cpu_to_le32(1 << 0);
-       log->iocs[nvme_cmd_zone_mgmt_recv]      = cpu_to_le32(1 << 0);
+       log->iocs[nvme_cmd_zone_append] =
+       log->iocs[nvme_cmd_zone_mgmt_send] =
+       log->iocs[nvme_cmd_zone_mgmt_recv] =
+               cpu_to_le32(NVME_CMD_EFFECTS_CSUPP);
 }
 
 static void nvmet_execute_get_log_cmd_effects_ns(struct nvmet_req *req)