OSDN Git Service

dpaa2-eth: Add a couple of macros
authorIoana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Tue, 16 Apr 2019 17:13:29 +0000 (17:13 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Apr 2019 04:46:19 +0000 (21:46 -0700)
Add two macros to simplify reading DPNI options.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h

index 1cbef6c..b04ad06 100644 (file)
@@ -2810,8 +2810,7 @@ static int dpaa2_eth_set_cls(struct dpaa2_eth_priv *priv)
                return -EOPNOTSUPP;
        }
 
-       if (priv->dpni_attrs.options & DPNI_OPT_NO_FS ||
-           !(priv->dpni_attrs.options & DPNI_OPT_HAS_KEY_MASKING)) {
+       if (!dpaa2_eth_fs_enabled(priv) || !dpaa2_eth_fs_mask_enabled(priv)) {
                dev_dbg(dev, "Rx cls disabled in DPNI options\n");
                return -EOPNOTSUPP;
        }
index a11ebfd..958955c 100644 (file)
@@ -437,6 +437,12 @@ static inline int dpaa2_eth_cmp_dpni_ver(struct dpaa2_eth_priv *priv,
        (dpaa2_eth_cmp_dpni_ver((priv), DPNI_RX_DIST_KEY_VER_MAJOR,     \
                                DPNI_RX_DIST_KEY_VER_MINOR) < 0)
 
+#define dpaa2_eth_fs_enabled(priv)     \
+       (!((priv)->dpni_attrs.options & DPNI_OPT_NO_FS))
+
+#define dpaa2_eth_fs_mask_enabled(priv)        \
+       ((priv)->dpni_attrs.options & DPNI_OPT_HAS_KEY_MASKING)
+
 #define dpaa2_eth_fs_count(priv)        \
        ((priv)->dpni_attrs.fs_entries)