OSDN Git Service

net: stmmac: drop redundant check in stmmac_mdio_reset
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sat, 15 Jun 2019 10:09:28 +0000 (12:09 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 16 Jun 2019 20:53:41 +0000 (13:53 -0700)
A simplified version of the existing code looks like this:
  if (priv->device->of_node) {
      struct device_node *np = priv->device->of_node;
      if (!np)
          return 0;

The second "if" never evaluates to true because the first "if" checks
for exactly the opposite.
Drop the redundant check and early return to make the code easier to
understand.

No functional changes intended.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

index f1c39dd..21bbe3b 100644 (file)
@@ -256,9 +256,6 @@ int stmmac_mdio_reset(struct mii_bus *bus)
                if (data->reset_gpio < 0) {
                        struct device_node *np = priv->device->of_node;
 
-                       if (!np)
-                               return 0;
-
                        reset_gpio = devm_gpiod_get_optional(priv->device,
                                                             "snps,reset",
                                                             GPIOD_OUT_LOW);