OSDN Git Service

brcmfmac: Remove always false 'idx < 0' statement
authoryuehaibing <yuehaibing@huawei.com>
Wed, 8 Jan 2020 13:57:48 +0000 (21:57 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Sun, 26 Jan 2020 15:43:28 +0000 (17:43 +0200)
idx is declared as u32, it will never less than 0.

Signed-off-by: yuehaibing <yuehaibing@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c

index e3dd862..8bb4f1f 100644 (file)
@@ -365,7 +365,7 @@ brcmf_msgbuf_get_pktid(struct device *dev, struct brcmf_msgbuf_pktids *pktids,
        struct brcmf_msgbuf_pktid *pktid;
        struct sk_buff *skb;
 
-       if (idx < 0 || idx >= pktids->array_size) {
+       if (idx >= pktids->array_size) {
                brcmf_err("Invalid packet id %d (max %d)\n", idx,
                          pktids->array_size);
                return NULL;