OSDN Git Service

media: s5k6a3: add missing clk_disable_unprepare
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 2 May 2022 07:18:54 +0000 (09:18 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 13 May 2022 09:02:22 +0000 (11:02 +0200)
Fix smatch warning:

drivers/media/i2c/s5k6a3.c:234 __s5k6a3_power_on() warn: 'sensor->clock' from clk_prepare_enable() not released on lines: 234.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/s5k6a3.c

index b97dd61..f6ecf6f 100644 (file)
@@ -213,7 +213,7 @@ static int __s5k6a3_power_on(struct s5k6a3 *sensor)
        for (i++; i < S5K6A3_NUM_SUPPLIES; i++) {
                ret = regulator_enable(sensor->supplies[i].consumer);
                if (ret < 0)
-                       goto error_reg_dis;
+                       goto error_clk;
        }
 
        gpio_set_value(sensor->gpio_reset, 1);
@@ -226,6 +226,8 @@ static int __s5k6a3_power_on(struct s5k6a3 *sensor)
        msleep(20);
        return 0;
 
+error_clk:
+       clk_disable_unprepare(sensor->clock);
 error_reg_dis:
        for (--i; i >= 0; --i)
                regulator_disable(sensor->supplies[i].consumer);