OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cbe8676
)
net/qla3xxx: fix potential memleak in ql3xxx_send()
author
Zhang Changzhong
<zhangchangzhong@huawei.com>
Thu, 17 Nov 2022 08:50:38 +0000
(16:50 +0800)
committer
Jakub Kicinski
<kuba@kernel.org>
Sat, 19 Nov 2022 03:39:05 +0000
(19:39 -0800)
The ql3xxx_send() returns NETDEV_TX_OK without freeing skb in error
handling case, add dev_kfree_skb_any() to fix it.
Fixes:
bd36b0ac5d06
("qla3xxx: Add support for Qlogic 4032 chip.")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link:
https://lore.kernel.org/r/1668675039-21138-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qla3xxx.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/qlogic/qla3xxx.c
b/drivers/net/ethernet/qlogic/qla3xxx.c
index
76072f8
..
0d57ffc
100644
(file)
--- a/
drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/
drivers/net/ethernet/qlogic/qla3xxx.c
@@
-2471,6
+2471,7
@@
static netdev_tx_t ql3xxx_send(struct sk_buff *skb,
skb_shinfo(skb)->nr_frags);
if (tx_cb->seg_count == -1) {
netdev_err(ndev, "%s: invalid segment count!\n", __func__);
+ dev_kfree_skb_any(skb);
return NETDEV_TX_OK;
}