OSDN Git Service

ANDROID: sdcardfs: Remove unnecessary lock
authorDaniel Rosenberg <drosen@google.com>
Thu, 20 Jul 2017 00:16:43 +0000 (17:16 -0700)
committerAmit Pundir <amit.pundir@linaro.org>
Tue, 14 Aug 2018 12:17:11 +0000 (17:47 +0530)
The mmap_sem lock does not appear to be protecting
anything, and has been removed in Samsung's more
recent versions of sdcardfs.

Signed-off-by: Daniel Rosenberg <drosen@google.com>
Change-Id: I76ff3e33002716b8384fc8be368028ed63dffe4e
Bug: 63785372

fs/sdcardfs/inode.c

index a3f7c8e..70a4e3c 100644 (file)
@@ -776,13 +776,9 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
         * afterwards in the other cases: we fsstack_copy_inode_size from
         * the lower level.
         */
-       if (current->mm)
-               down_write(&current->mm->mmap_sem);
        if (ia->ia_valid & ATTR_SIZE) {
                err = inode_newsize_ok(&tmp, ia->ia_size);
                if (err) {
-                       if (current->mm)
-                               up_write(&current->mm->mmap_sem);
                        goto out;
                }
                truncate_setsize(inode, ia->ia_size);
@@ -805,8 +801,6 @@ static int sdcardfs_setattr(struct vfsmount *mnt, struct dentry *dentry, struct
        err = notify_change2(lower_mnt, lower_dentry, &lower_ia, /* note: lower_ia */
                        NULL);
        inode_unlock(d_inode(lower_dentry));
-       if (current->mm)
-               up_write(&current->mm->mmap_sem);
        if (err)
                goto out;