OSDN Git Service

xfs: remove unnecessary ternary from xfs_create
authorKaixu Xia <kaixuxia@tencent.com>
Fri, 27 Mar 2020 15:28:39 +0000 (08:28 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Sat, 28 Mar 2020 16:40:11 +0000 (09:40 -0700)
Since the "no-allocation" reservations for file creations has
been removed, the resblks value should be larger than zero, so
remove unnecessary ternary conditional.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[darrick: s/judgment/ternary/]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_inode.c

index 5c93086..0cac0d3 100644 (file)
@@ -1200,8 +1200,7 @@ xfs_create(
        unlock_dp_on_error = false;
 
        error = xfs_dir_createname(tp, dp, name, ip->i_ino,
-                                  resblks ?
-                                       resblks - XFS_IALLOC_SPACE_RES(mp) : 0);
+                                       resblks - XFS_IALLOC_SPACE_RES(mp));
        if (error) {
                ASSERT(error != -ENOSPC);
                goto out_trans_cancel;