OSDN Git Service

ath10k: Release some resources in an error handling path
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 24 Nov 2020 15:59:18 +0000 (17:59 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 2 Dec 2020 18:31:54 +0000 (20:31 +0200)
Should an error occur after calling 'ath10k_usb_create()', it should be
undone by a corresponding 'ath10k_usb_destroy()' call

Fixes: 4db66499df91 ("ath10k: add initial USB support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201122170358.1346065-1-christophe.jaillet@wanadoo.fr
drivers/net/wireless/ath/ath10k/usb.c

index 0b47c3a..19b9c27 100644 (file)
@@ -1011,7 +1011,7 @@ static int ath10k_usb_probe(struct usb_interface *interface,
        ret = ath10k_core_register(ar, &bus_params);
        if (ret) {
                ath10k_warn(ar, "failed to register driver core: %d\n", ret);
-               goto err;
+               goto err_usb_destroy;
        }
 
        /* TODO: remove this once USB support is fully implemented */
@@ -1019,6 +1019,9 @@ static int ath10k_usb_probe(struct usb_interface *interface,
 
        return 0;
 
+err_usb_destroy:
+       ath10k_usb_destroy(ar);
+
 err:
        ath10k_core_destroy(ar);