OSDN Git Service

staging: rtl8188eu: change type of is_cck_rate - style
authorMichael Straube <straube.linux@gmail.com>
Sun, 21 Oct 2018 19:45:28 +0000 (21:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Nov 2018 11:41:00 +0000 (12:41 +0100)
The variable is_cck_rate is used for boolean values, so change the
type from u8 to bool. The initializations to zero and use of ternary
operator in the assignments are unnecessary, remove them as well.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/odm_hwconfig.c

index 5d72d7f..7ae476f 100644 (file)
@@ -71,15 +71,15 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
        s8 rx_pwr[4], rx_pwr_all = 0;
        u8 EVM, PWDB_ALL = 0, PWDB_ALL_BT;
        u8 RSSI, total_rssi = 0;
-       u8 is_cck_rate = 0;
+       bool is_cck_rate;
        u8 rf_rx_num = 0;
        u8 cck_highpwr = 0;
        u8 LNA_idx, VGA_idx;
 
        struct phy_status_rpt *pPhyStaRpt = (struct phy_status_rpt *)pPhyStatus;
 
-       is_cck_rate = ((pPktinfo->Rate >= DESC92C_RATE1M) &&
-                      (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
+       is_cck_rate = pPktinfo->Rate >= DESC92C_RATE1M &&
+                     pPktinfo->Rate <= DESC92C_RATE11M;
 
        pPhyInfo->RxMIMOSignalQuality[RF_PATH_A] = -1;
        pPhyInfo->RxMIMOSignalQuality[RF_PATH_B] = -1;
@@ -256,7 +256,7 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct *dm_odm,
 {
        s32 UndecoratedSmoothedPWDB, UndecoratedSmoothedCCK;
        s32 UndecoratedSmoothedOFDM, RSSI_Ave;
-       u8 is_cck_rate = 0;
+       bool is_cck_rate;
        u8 RSSI_max, RSSI_min, i;
        u32 OFDM_pkt = 0;
        u32 Weighting = 0;
@@ -272,8 +272,8 @@ static void odm_Process_RSSIForDM(struct odm_dm_struct *dm_odm,
        if ((!pPktinfo->bPacketMatchBSSID))
                return;
 
-       is_cck_rate = ((pPktinfo->Rate >= DESC92C_RATE1M) &&
-                      (pPktinfo->Rate <= DESC92C_RATE11M)) ? true : false;
+       is_cck_rate = pPktinfo->Rate >= DESC92C_RATE1M &&
+                     pPktinfo->Rate <= DESC92C_RATE11M;
 
        /* Smart Antenna Debug Message------------------  */