OSDN Git Service

tools/power/x86/intel-speed-select: Ignore -o option processing on error
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Tue, 30 Jun 2020 17:45:36 +0000 (10:45 -0700)
committerSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thu, 16 Jul 2020 17:17:33 +0000 (10:17 -0700)
When for some reason, CONFIG_TDP_GET_CORE_MASK mailbox command fails, then
don't continue online/offline operation for perf-profile set-config-level
with "-o" option.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
tools/power/x86/intel-speed-select/isst-config.c

index 2d10def..0a5c174 100644 (file)
@@ -1247,7 +1247,11 @@ static void set_tdp_level_for_cpu(int cpu, void *arg1, void *arg2, void *arg3,
                        fprintf(stderr, "Option is set to online/offline\n");
                        ctdp_level.core_cpumask_size =
                                alloc_cpu_set(&ctdp_level.core_cpumask);
-                       isst_get_coremask_info(cpu, tdp_level, &ctdp_level);
+                       ret = isst_get_coremask_info(cpu, tdp_level, &ctdp_level);
+                       if (ret) {
+                               isst_display_error_info_message(1, "Can't get coremask, online/offline option is ignored", 0, 0);
+                               return;
+                       }
                        if (ctdp_level.cpu_count) {
                                int i, max_cpus = get_topo_max_cpus();
                                for (i = 0; i < max_cpus; ++i) {