OSDN Git Service

ch: remove debug noise in ch_do_scsi
authorChristoph Hellwig <hch@lst.de>
Sun, 18 Jan 2015 15:11:30 +0000 (16:11 +0100)
committerChristoph Hellwig <hch@lst.de>
Tue, 20 Jan 2015 18:43:23 +0000 (19:43 +0100)
The midlayer logging already prints the cdb details if the logging
level is high enough, no need to duplicate this in the ch driver.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: James Bottomley <JBottomley@Parallels.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
drivers/scsi/ch.c

index 79e462f..0045742 100644 (file)
@@ -194,18 +194,10 @@ ch_do_scsi(scsi_changer *ch, unsigned char *cmd, int cmd_len,
 
  retry:
        errno = 0;
-       if (debug) {
-               char logbuf[SCSI_LOG_BUFSIZE];
-
-               __scsi_format_command(logbuf, sizeof(logbuf), cmd, cmd_len);
-               DPRINTK("command: %s", logbuf);
-       }
-
        result = scsi_execute_req(ch->device, cmd, direction, buffer,
                                  buflength, &sshdr, timeout * HZ,
                                  MAX_RETRIES, NULL);
 
-       DPRINTK("result: 0x%x\n",result);
        if (driver_byte(result) & DRIVER_SENSE) {
                if (debug)
                        scsi_print_sense_hdr(ch->device, ch->name, &sshdr);