OSDN Git Service

bcache: add comments for closure_fn to be called in closure_queue()
authorColy Li <colyli@suse.de>
Wed, 24 Apr 2019 16:48:39 +0000 (00:48 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 24 Apr 2019 16:56:28 +0000 (10:56 -0600)
Add code comments to explain which call back function might be called
for the closure_queue(). This is an effort to make code to be more
understandable for readers.

Signed-off-by: Coly Li <colyli@suse.de>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c

index fa856b2..0363ab5 100644 (file)
@@ -662,6 +662,11 @@ static const struct block_device_operations bcache_ops = {
 void bcache_device_stop(struct bcache_device *d)
 {
        if (!test_and_set_bit(BCACHE_DEV_CLOSING, &d->flags))
+               /*
+                * closure_fn set to
+                * - cached device: cached_dev_flush()
+                * - flash dev: flash_dev_flush()
+                */
                closure_queue(&d->cl);
 }
 
@@ -1675,6 +1680,7 @@ static void __cache_set_unregister(struct closure *cl)
 void bch_cache_set_stop(struct cache_set *c)
 {
        if (!test_and_set_bit(CACHE_SET_STOPPING, &c->flags))
+               /* closure_fn set to __cache_set_unregister() */
                closure_queue(&c->caching);
 }