OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7c2fc79
)
phy: cadence: Sierra: Fix error return code in cdns_sierra_phy_probe()
author
Wang Wensheng
<wangwensheng4@huawei.com>
Mon, 17 May 2021 01:57:49 +0000
(
01:57
+0000)
committer
Vinod Koul
<vkoul@kernel.org>
Mon, 31 May 2021 08:20:05 +0000
(13:50 +0530)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes:
a43f72ae136a
("phy: cadence: Sierra: Change MAX_LANES of Sierra to 16")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
Link:
https://lore.kernel.org/r/20210517015749.127799-1-wangwensheng4@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/cadence/phy-cadence-sierra.c
patch
|
blob
|
history
diff --git
a/drivers/phy/cadence/phy-cadence-sierra.c
b/drivers/phy/cadence/phy-cadence-sierra.c
index
5c68e31
..
e93818e
100644
(file)
--- a/
drivers/phy/cadence/phy-cadence-sierra.c
+++ b/
drivers/phy/cadence/phy-cadence-sierra.c
@@
-940,6
+940,7
@@
static int cdns_sierra_phy_probe(struct platform_device *pdev)
sp->nsubnodes = node;
if (sp->num_lanes > SIERRA_MAX_LANES) {
+ ret = -EINVAL;
dev_err(dev, "Invalid lane configuration\n");
goto put_child2;
}