OSDN Git Service

kconfig: do not assign a variable in the return statement
authorMasahiro Yamada <masahiroy@kernel.org>
Mon, 13 Apr 2020 15:35:42 +0000 (00:35 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Tue, 12 May 2020 04:28:30 +0000 (13:28 +0900)
I am not a big fan of doing assignment in a return statement.
Split it into two lines.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/menu.c

index e436ba4..a5fbd6c 100644 (file)
@@ -65,7 +65,8 @@ void menu_add_entry(struct symbol *sym)
 struct menu *menu_add_menu(void)
 {
        last_entry_ptr = &current_entry->list;
-       return current_menu = current_entry;
+       current_menu = current_entry;
+       return current_menu;
 }
 
 void menu_end_menu(void)