OSDN Git Service

media: vcodec: fix error return value from mtk_jpeg_clk_init()
authorRyder Lee <ryder.lee@mediatek.com>
Fri, 23 Mar 2018 03:44:13 +0000 (23:44 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 10:12:52 +0000 (06:12 -0400)
The error return value should be fixed as it may return EPROBE_DEFER.

Cc: Bin Liu <bin.liu@mediatek.com>
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Rick Chang <rick.chang@mediatek.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c

index 226f908..af17aaa 100644 (file)
@@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct mtk_jpeg_dev *jpeg)
 
        jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec");
        if (IS_ERR(jpeg->clk_jdec))
-               return -EINVAL;
+               return PTR_ERR(jpeg->clk_jdec);
 
        jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi");
        if (IS_ERR(jpeg->clk_jdec_smi))
-               return -EINVAL;
+               return PTR_ERR(jpeg->clk_jdec_smi);
 
        return 0;
 }