OSDN Git Service

arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disallow regulator mode switches
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 3 Aug 2022 12:19:41 +0000 (14:19 +0200)
committerBjorn Andersson <andersson@kernel.org>
Mon, 29 Aug 2022 21:58:16 +0000 (16:58 -0500)
Do not allow the RPMh regulators to switch to low-power mode.

This specifically avoids having regulators be but in low-power mode when
only some consumers specify loads while the actual total load really
warrants high-power mode.

Fixes: 32c231385ed4 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree")
Link: https://lore.kernel.org/all/YtkrDcjTGhpaU1e0@hovoldconsulting.com
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220803121942.30236-3-johan+linaro@kernel.org
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

index 16c6e4d..bdeb2d0 100644 (file)
@@ -79,7 +79,6 @@
                        regulator-min-microvolt = <1200000>;
                        regulator-max-microvolt = <1200000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                        regulator-boot-on;
                };
 
@@ -88,7 +87,6 @@
                        regulator-min-microvolt = <912000>;
                        regulator-max-microvolt = <912000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
 
                vreg_l6b: ldo6 {
@@ -96,7 +94,6 @@
                        regulator-min-microvolt = <880000>;
                        regulator-max-microvolt = <880000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                        regulator-boot-on;
                        regulator-always-on;    // FIXME: VDD_A_EDP_0_0P9
                };
                        regulator-min-microvolt = <1800000>;
                        regulator-max-microvolt = <1800000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
 
                vreg_l12c: ldo12 {
                        regulator-min-microvolt = <1800000>;
                        regulator-max-microvolt = <1800000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
 
                vreg_l13c: ldo13 {
                        regulator-min-microvolt = <3072000>;
                        regulator-max-microvolt = <3072000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
        };
 
                        regulator-min-microvolt = <1200000>;
                        regulator-max-microvolt = <1200000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
 
                vreg_l4d: ldo4 {
                        regulator-min-microvolt = <1200000>;
                        regulator-max-microvolt = <1200000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
 
                vreg_l7d: ldo7 {
                        regulator-min-microvolt = <3072000>;
                        regulator-max-microvolt = <3072000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
 
                vreg_l9d: ldo9 {
                        regulator-min-microvolt = <912000>;
                        regulator-max-microvolt = <912000>;
                        regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-                       regulator-allow-set-load;
                };
        };
 };