media: tc358743: release device_node in tc358743_probe_of()

of_graph_get_next_endpoint() returns device_node with refcnt increased,
but these is no of_node_put() for it.

The patch adds one on error and normal paths.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 393bbbb..44c4193 100644 (file)
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1918,7 +1918,8 @@ static int tc358743_probe_of(struct tc358743_state *state)
        endpoint = v4l2_fwnode_endpoint_alloc_parse(of_fwnode_handle(ep));
        if (IS_ERR(endpoint)) {
                dev_err(dev, "failed to parse endpoint\n");
-               return PTR_ERR(endpoint);
+               ret = PTR_ERR(endpoint);
+               goto put_node;
        }
 
        if (endpoint->bus_type != V4L2_MBUS_CSI2 ||
@@ -2013,6 +2014,8 @@ disable_clk:
        clk_disable_unprepare(refclk);
 free_endpoint:
        v4l2_fwnode_endpoint_free(endpoint);
+put_node:
+       of_node_put(ep);
        return ret;
 }
 #else