OSDN Git Service

rtlwifi: silence underflow warning
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 29 Sep 2017 07:52:34 +0000 (10:52 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 10 Oct 2017 08:19:26 +0000 (11:19 +0300)
My static checker complains that we have an upper bound but no lower
bound.  I suspect neither are really required but it doesn't hurt to add
a check for negatives.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/core.c

index c53cbf3..294a6b4 100644 (file)
@@ -453,7 +453,8 @@ static void _rtl_add_wowlan_patterns(struct ieee80211_hw *hw,
        for (i = 0; i < wow->n_patterns; i++) {
                memset(&rtl_pattern, 0, sizeof(struct rtl_wow_pattern));
                memset(mask, 0, MAX_WOL_BIT_MASK_SIZE);
-               if (patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
+               if (patterns[i].pattern_len < 0 ||
+                   patterns[i].pattern_len > MAX_WOL_PATTERN_SIZE) {
                        RT_TRACE(rtlpriv, COMP_POWER, DBG_WARNING,
                                 "Pattern[%d] is too long\n", i);
                        continue;