OSDN Git Service

nfp: replace spin_lock_bh with spin_lock in tasklet callback
authorjun qian <hangdianqj@163.com>
Fri, 7 Sep 2018 17:01:09 +0000 (10:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 8 Sep 2018 05:56:02 +0000 (22:56 -0700)
As you are already in a tasklet, it is unnecessary to call spin_lock_bh.

Signed-off-by: jun qian <hangdianqj@163.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c

index a2f88ae..17a4785 100644 (file)
@@ -2091,10 +2091,10 @@ static void nfp_ctrl_poll(unsigned long arg)
 {
        struct nfp_net_r_vector *r_vec = (void *)arg;
 
-       spin_lock_bh(&r_vec->lock);
+       spin_lock(&r_vec->lock);
        nfp_net_tx_complete(r_vec->tx_ring, 0);
        __nfp_ctrl_tx_queued(r_vec);
-       spin_unlock_bh(&r_vec->lock);
+       spin_unlock(&r_vec->lock);
 
        nfp_ctrl_rx(r_vec);