OSDN Git Service

media: s5p-jpeg: don't overwrite result's "size" member
authorAndrzej Pietrasiewicz <andrzej.p@samsung.com>
Fri, 11 Aug 2017 11:50:00 +0000 (07:50 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sun, 20 Aug 2017 11:59:52 +0000 (07:59 -0400)
Originally the "size" member was modified in a local variable passed to
s5p_jpeg_parse_hdr() but the member was not used by the caller, so it did
not matter. After applying patch
"media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue"
the unnecessary assignment started overwriting already assigned "size"
member of the passed structure with an incorrect value.

Fixes: 14a2de14dc0619bf9 ("media: s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue")

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/s5p-jpeg/jpeg-core.c

index 4cef4b8..c00e3a1 100644 (file)
@@ -1264,7 +1264,7 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
        }
        result->sof = sof;
        result->sof_len = sof_len;
-       result->size = result->components = components;
+       result->components = components;
 
        return true;
 }