OSDN Git Service

fix recursion in case QBitmap is constructed with null pixmap
authorIvailo Monev <xakepa10@laimg.moc>
Sun, 26 May 2019 16:07:21 +0000 (16:07 +0000)
committerIvailo Monev <xakepa10@laimg.moc>
Sun, 26 May 2019 16:07:21 +0000 (16:07 +0000)
Signed-off-by: Ivailo Monev <xakepa10@laimg.moc>
src/gui/image/qbitmap.cpp

index d6f6bd4..696cf5f 100644 (file)
@@ -192,16 +192,7 @@ QBitmap::QBitmap(const QString& fileName, const char *format)
 
 QBitmap &QBitmap::operator=(const QPixmap &pixmap)
 {
-    if (pixmap.isNull()) {                        // a null pixmap
-        QBitmap bm(0, 0);
-        QBitmap::operator=(bm);
-    } else if (pixmap.depth() == 1) {                // 1-bit pixmap
-        QPixmap::operator=(pixmap);                // shallow assignment
-    } else {                                        // n-bit depth pixmap
-        QImage image;
-        image = pixmap.toImage();                                // convert pixmap to image
-        *this = fromImage(image);                                // will dither image
-    }
+    *this = fromImage(pixmap.toImage());
     return *this;
 }