Fix typo in PQconnectStartParams().

This would lead to leaking the PGconn structure after an error detected by
conninfo_array_parse(), as well as failing to return a useful error message
in such cases.  Backpatch to 9.0 where the error was introduced.

Joseph Adams

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 4c59ca6..6eb6492 100644 (file)
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -446,7 +446,7 @@ PQconnectStartParams(const char **keywords,
        {
                conn->status = CONNECTION_BAD;
                /* errorMessage is already set */
-               return false;
+               return conn;
        }
 
        /*