OSDN Git Service

powerpc/cacheinfo: Remove double free
authorTobin C. Harding <tobin@kernel.org>
Wed, 15 May 2019 09:07:50 +0000 (19:07 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 17 May 2019 13:28:00 +0000 (23:28 +1000)
kfree() after kobject_put(). Who ever wrote this was on crack.

Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak")
Signed-off-by: Tobin C. Harding <tobin@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/cacheinfo.c

index f2ed3ef..862e289 100644 (file)
@@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index,
                                  cache_dir->kobj, "index%d", index);
        if (rc) {
                kobject_put(&index_dir->kobj);
-               kfree(index_dir);
                return;
        }