OSDN Git Service

pinctrl: sh-pfc: gpio: Return early in gpio_pin_to_irq()
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 12 Feb 2020 09:02:00 +0000 (10:02 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 21 Feb 2020 12:57:44 +0000 (13:57 +0100)
As of commit 4adeabd042422cee ("pinctrl: sh-pfc: Remove hardcoded IRQ
numbers"), only a single operation needs to be performed after finding
the wanted pin.  Hence decrease the needed attention span of the casual
reader by replacing the goto by a direct return.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20200212090200.11106-1-geert+renesas@glider.be
drivers/pinctrl/sh-pfc/gpio.c

index 8213e11..9c6e931 100644 (file)
@@ -205,14 +205,11 @@ static int gpio_pin_to_irq(struct gpio_chip *gc, unsigned offset)
 
                for (k = 0; gpios[k] >= 0; k++) {
                        if (gpios[k] == offset)
-                               goto found;
+                               return pfc->irqs[i];
                }
        }
 
        return 0;
-
-found:
-       return pfc->irqs[i];
 }
 
 static int gpio_pin_setup(struct sh_pfc_chip *chip)