OSDN Git Service

netfilter: nft_meta_bridge: Eliminate 'out' label
authorPhil Sutter <phil@nwl.cc>
Tue, 23 Jul 2019 13:27:53 +0000 (15:27 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 25 Jul 2019 06:38:29 +0000 (08:38 +0200)
The label is used just once and the code it points at is not reused, no
point in keeping it.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/bridge/netfilter/nft_meta_bridge.c

index a98dec2..1804e86 100644 (file)
@@ -57,13 +57,11 @@ static void nft_meta_bridge_get_eval(const struct nft_expr *expr,
                return;
        }
        default:
-               goto out;
+               return nft_meta_get_eval(expr, regs, pkt);
        }
 
        strncpy((char *)dest, br_dev ? br_dev->name : "", IFNAMSIZ);
        return;
-out:
-       return nft_meta_get_eval(expr, regs, pkt);
 err:
        regs->verdict.code = NFT_BREAK;
 }