OSDN Git Service

ASoC: rt1011: some minor changes to improve readability
authorShuming Fan <shumingf@realtek.com>
Thu, 31 Oct 2019 11:54:46 +0000 (19:54 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 31 Oct 2019 13:20:17 +0000 (14:20 +0100)
There is no other code use the RT1011_INIT_REG_LEN definition,
except rt1011_reg_init().
Hence, we remove it and fix the typo.

Signed-off-by: Shuming Fan <shumingf@realtek.com>
Link: https://lore.kernel.org/r/20191031115446.21108-1-shumingf@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1011.c

index f2c581b..2552073 100644 (file)
@@ -61,7 +61,6 @@ static const struct reg_sequence init_list[] = {
        { RT1011_DAC_SET_1, 0xe702 },
        { RT1011_DAC_SET_3, 0x2004 },
 };
-#define RT1011_INIT_REG_LEN ARRAY_SIZE(init_list)
 
 static const struct reg_default rt1011_reg[] = {
        {0x0000, 0x0000},
@@ -684,7 +683,8 @@ static int rt1011_reg_init(struct snd_soc_component *component)
 {
        struct rt1011_priv *rt1011 = snd_soc_component_get_drvdata(component);
 
-       regmap_multi_reg_write(rt1011->regmap, init_list, RT1011_INIT_REG_LEN);
+       regmap_multi_reg_write(rt1011->regmap,
+               init_list, ARRAY_SIZE(init_list));
        return 0;
 }
 
@@ -1773,7 +1773,8 @@ static int rt1011_set_component_pll(struct snd_soc_component *component,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n",
+                       freq_in);
                return ret;
        }
 
@@ -2384,7 +2385,7 @@ static int rt1011_i2c_probe(struct i2c_client *i2c,
 
        rt1011 = devm_kzalloc(&i2c->dev, sizeof(struct rt1011_priv),
                                GFP_KERNEL);
-       if (rt1011 == NULL)
+       if (!rt1011)
                return -ENOMEM;
 
        i2c_set_clientdata(i2c, rt1011);