OSDN Git Service

net: ethernet: slicoss: remove redundant initialization of idx
authorColin Ian King <colin.king@canonical.com>
Tue, 31 Oct 2017 10:08:23 +0000 (10:08 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Nov 2017 12:19:32 +0000 (21:19 +0900)
Variable idx is being initialized and later on over-written by
a new value in a do-loop without the initial value ever being
read. Hence the initializion is redundant and can be removed.
Cleans up clang warning:

drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value
stored to 'idx' during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/alacritech/slicoss.c

index 15a8096..0b60921 100644 (file)
@@ -355,10 +355,10 @@ static void slic_xmit_complete(struct slic_device *sdev)
 {
        struct slic_tx_queue *txq = &sdev->txq;
        struct net_device *dev = sdev->netdev;
-       unsigned int idx = txq->done_idx;
        struct slic_tx_buffer *buff;
        unsigned int frames = 0;
        unsigned int bytes = 0;
+       unsigned int idx;
 
        /* Limit processing to SLIC_MAX_TX_COMPLETIONS frames to avoid that new
         * completions during processing keeps the loop running endlessly.