OSDN Git Service

staging: comedi: gsc_hpdi: remove deadcode in gsc_hpdi_cmd_test()
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 25 Aug 2014 22:23:57 +0000 (15:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 20:20:51 +0000 (13:20 -0700)
Reported by: coverity
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/gsc_hpdi.c

index 91c1e8c..c193910 100644 (file)
@@ -422,12 +422,10 @@ static int gsc_hpdi_cmd_test(struct comedi_device *dev,
        if (err)
                return 3;
 
-       /* step 4: fix up any arguments */
-
-       if (err)
-               return 4;
+       /* Step 4: fix up any arguments */
 
        /* Step 5: check channel list if it exists */
+
        if (cmd->chanlist && cmd->chanlist_len > 0)
                err |= gsc_hpdi_check_chanlist(dev, s, cmd);