OSDN Git Service

net, core: Allow netdev_lower_get_next_private_rcu in bh context
authorJussi Maki <joamaki@gmail.com>
Sat, 31 Jul 2021 05:57:36 +0000 (05:57 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 9 Aug 2021 21:25:15 +0000 (23:25 +0200)
For the XDP bonding slave lookup to work in the NAPI poll context in which
the redudant rcu_read_lock() has been removed we have to follow the same
approach as in 694cea395fde ("bpf: Allow RCU-protected lookups to happen
from bh context") and modify the WARN_ON to also check rcu_read_lock_bh_held().

Signed-off-by: Jussi Maki <joamaki@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/bpf/20210731055738.16820-6-joamaki@gmail.com
net/core/dev.c

index 9eb6dc9..e5045b6 100644 (file)
@@ -7615,7 +7615,7 @@ void *netdev_lower_get_next_private_rcu(struct net_device *dev,
 {
        struct netdev_adjacent *lower;
 
-       WARN_ON_ONCE(!rcu_read_lock_held());
+       WARN_ON_ONCE(!rcu_read_lock_held() && !rcu_read_lock_bh_held());
 
        lower = list_entry_rcu((*iter)->next, struct netdev_adjacent, list);