OSDN Git Service
(root)
/
tomoyo
/
tomoyo-test1.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1eca1d4
)
can: m_can: Add check for devm_clk_get
author
Jiasheng Jiang
<jiasheng@iscas.ac.cn>
Wed, 23 Nov 2022 06:36:51 +0000
(14:36 +0800)
committer
Marc Kleine-Budde
<mkl@pengutronix.de>
Thu, 24 Nov 2022 15:10:18 +0000
(16:10 +0100)
Since the devm_clk_get may return error,
it should be better to add check for the cdev->hclk,
as same as cdev->cclk.
Fixes:
f524f829b75a
("can: m_can: Create a m_can platform framework")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link:
https://lore.kernel.org/all/20221123063651.26199-1-jiasheng@iscas.ac.cn
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c
patch
|
blob
|
history
diff --git
a/drivers/net/can/m_can/m_can.c
b/drivers/net/can/m_can/m_can.c
index
00d11e9
..
e5575d2
100644
(file)
--- a/
drivers/net/can/m_can/m_can.c
+++ b/
drivers/net/can/m_can/m_can.c
@@
-1909,7
+1909,7
@@
int m_can_class_get_clocks(struct m_can_classdev *cdev)
cdev->hclk = devm_clk_get(cdev->dev, "hclk");
cdev->cclk = devm_clk_get(cdev->dev, "cclk");
- if (IS_ERR(cdev->cclk)) {
+ if (IS_ERR(cdev->
hclk) || IS_ERR(cdev->
cclk)) {
dev_err(cdev->dev, "no clock found\n");
ret = -ENODEV;
}