OSDN Git Service

scsi: sd_zbc: Remove an assignment from sd_zbc_setup_report_cmnd()
authorBart Van Assche <bart.vanassche@wdc.com>
Thu, 28 Jun 2018 15:31:28 +0000 (08:31 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 2 Jul 2018 20:18:11 +0000 (16:18 -0400)
Since nr_bytes == blk_rq_bytes(rq) == rq->__data_len, the
rq->__data_len = nr_bytes assignment does not modify the value of
rq->__data_len. Hence remove that assignment. Note: the code in
sd_done() that sets the residual to zero for zone report requests
is not affected by this patch.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd_zbc.c

index a14fef1..160b796 100644 (file)
@@ -148,12 +148,6 @@ int sd_zbc_setup_report_cmnd(struct scsi_cmnd *cmd)
        cmd->transfersize = sdkp->device->sector_size;
        cmd->allowed = 0;
 
-       /*
-        * Report may return less bytes than requested. Make sure
-        * to report completion on the entire initial request.
-        */
-       rq->__data_len = nr_bytes;
-
        return BLKPREP_OK;
 }