OSDN Git Service

net/mlx5: Fix error code in mlx5_is_reset_now_capable()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 20 Jun 2023 13:43:07 +0000 (16:43 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Fri, 23 Jun 2023 19:27:33 +0000 (12:27 -0700)
The mlx5_is_reset_now_capable() function returns bool, not negative
error codes.  So if fast teardown is not supported it should return
false instead of -EOPNOTSUPP.

Fixes: 92501fa6e421 ("net/mlx5: Ack on sync_reset_request only if PF can do reset_now")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/fw_reset.c

index 7af2b14..fb7874d 100644 (file)
@@ -327,7 +327,7 @@ static bool mlx5_is_reset_now_capable(struct mlx5_core_dev *dev)
 
        if (!MLX5_CAP_GEN(dev, fast_teardown)) {
                mlx5_core_warn(dev, "fast teardown is not supported by firmware\n");
-               return -EOPNOTSUPP;
+               return false;
        }
 
        err = pci_read_config_word(dev->pdev, PCI_DEVICE_ID, &dev_id);