OSDN Git Service

BufferQueue: check before tracing buffer index
authorJamie Gennis <jgennis@google.com>
Tue, 17 Apr 2012 03:34:58 +0000 (20:34 -0700)
committerJamie Gennis <jgennis@google.com>
Tue, 17 Apr 2012 03:36:25 +0000 (20:36 -0700)
This change adds a check on ATRACE_ENABLED before calling snprintf to trace the
buffer index.

Change-Id: Id79430f9c69706393efd3d10780a4cc97055e9e0

libs/gui/BufferQueue.cpp

index 01d08b7..ece0494 100644 (file)
 #define ST_LOGE(x, ...) ALOGE("[%s] "x, mConsumerName.string(), ##__VA_ARGS__)
 
 #define ATRACE_BUFFER_INDEX(index)                                            \
-    char ___traceBuf[1024];                                                   \
-    snprintf(___traceBuf, 1024, "%s: %d", mConsumerName.string(), (index));   \
-    android::ScopedTrace ___bufTracer(ATRACE_TAG, ___traceBuf);
+    if (ATRACE_ENABLED()) {                                                   \
+        char ___traceBuf[1024];                                               \
+        snprintf(___traceBuf, 1024, "%s: %d", mConsumerName.string(),         \
+                (index));                                                     \
+        android::ScopedTrace ___bufTracer(ATRACE_TAG, ___traceBuf);           \
+    }
 
 namespace android {