build_fh_name.
* fhandler_disk_file.cc (fhandler_disk_file::mkdir): Fix typo in
comment.
* fhandler_socket.cc (fhandler_socket::bind): Ditto.
* path.cc (symlink_worker): Ditto.
+2011-08-01 Corinna Vinschen <corinna@vinschen.de>
+
+ * syscalls.cc (faccessat): Fix parens in flag expression when calling
+ build_fh_name.
+
+ * fhandler_disk_file.cc (fhandler_disk_file::mkdir): Fix typo in
+ comment.
+ * fhandler_socket.cc (fhandler_socket::bind): Ditto.
+ * path.cc (symlink_worker): Ditto.
+
2011-07-31 Christopher Faylor <me.cygwin2011@cgf.cx>
* dll_init.cc (dll_list::load_after_fork_impl): Add a hint to an error
open the file again.
FIXME: On remote NTFS shares open sometimes fails because even the
creator of the file doesn't have the right to change the DACL.
- I don't know what setting that is or howq to recognize such a share,
+ I don't know what setting that is or how to recognize such a share,
so for now we don't request WRITE_DAC on remote drives. */
access |= READ_CONTROL | WRITE_DAC;
status = NtCreateFile (&dir, access, pc.get_object_attr (attr, sa), &io, NULL,
open the file again.
FIXME: On remote NTFS shares open sometimes fails because even the
creator of the file doesn't have the right to change the DACL.
- I don't know what setting that is or howq to recognize such a share,
+ I don't know what setting that is or how to recognize such a share,
so for now we don't request WRITE_DAC on remote drives. */
if (pc.has_acls () && !pc.isremote ())
access |= READ_CONTROL | WRITE_DAC;
open the file again.
FIXME: On remote NTFS shares open sometimes fails because even the
creator of the file doesn't have the right to change the DACL.
- I don't know what setting that is or howq to recognize such a share,
+ I don't know what setting that is or how to recognize such a share,
so for now we don't request WRITE_DAC on remote drives. */
access |= READ_CONTROL | WRITE_DAC;
set_errno (EINVAL);
else
{
- fhandler_base *fh = build_fh_name (path,
- PC_KEEP_HANDLE |
- (flags & AT_SYMLINK_NOFOLLOW)
- ? PC_SYM_NOFOLLOW : PC_SYM_FOLLOW,
+ fhandler_base *fh = build_fh_name (path, (flags & AT_SYMLINK_NOFOLLOW
+ ? PC_SYM_NOFOLLOW
+ : PC_SYM_FOLLOW)
+ | PC_KEEP_HANDLE,
stat_suffixes);
if (fh)
{
- res = fh->fhaccess (mode, flags & AT_EACCESS);
+ res = fh->fhaccess (mode, !!(flags & AT_EACCESS));
delete fh;
}
}