OSDN Git Service

scsi: iscsi: Drop temp workq_name
authorMike Christie <michael.christie@oracle.com>
Sat, 26 Feb 2022 23:04:35 +0000 (17:04 -0600)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 2 Mar 2022 04:56:28 +0000 (23:56 -0500)
When the workqueue code was created it didn't allow variable args so we
have been using a temp buffer. Drop that.

Link: https://lore.kernel.org/r/20220226230435.38733-7-michael.christie@oracle.com
Reviewed-by: Chris Leech <cleech@redhat.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libiscsi.c
include/scsi/libiscsi.h

index d69203d..c84c2a3 100644 (file)
@@ -2798,11 +2798,9 @@ struct Scsi_Host *iscsi_host_alloc(struct scsi_host_template *sht,
        ihost = shost_priv(shost);
 
        if (xmit_can_sleep) {
-               snprintf(ihost->workq_name, sizeof(ihost->workq_name),
-                       "iscsi_q_%d", shost->host_no);
-               ihost->workq = alloc_workqueue("%s",
+               ihost->workq = alloc_workqueue("iscsi_q_%d",
                        WQ_SYSFS | __WQ_LEGACY | WQ_MEM_RECLAIM | WQ_UNBOUND,
-                       1, ihost->workq_name);
+                       1, shost->host_no);
                if (!ihost->workq)
                        goto free_host;
        }
index cb805ed..e76c946 100644 (file)
@@ -383,7 +383,6 @@ struct iscsi_host {
        int                     state;
 
        struct workqueue_struct *workq;
-       char                    workq_name[20];
 };
 
 /*