OSDN Git Service

Fix dupicate preference in personal dict
authorTarandeep Singh <tarandeep@google.com>
Tue, 26 Mar 2019 18:26:58 +0000 (11:26 -0700)
committerTarandeep Singh <tarandeep@google.com>
Tue, 26 Mar 2019 18:45:40 +0000 (11:45 -0700)
Duplicate preference is added on the
UserDictionaryListPreferenceController. With this change, we check
before adding.

Fix: 129079798
Test: Manually using steps mentioned in bug
Change-Id: If73880f3be460f377b8985a44fc9f9fbe6370c06

src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java

index 4a409e1..9343493 100644 (file)
@@ -174,7 +174,10 @@ public class UserDictionaryListPreferenceController extends BasePreferenceContro
             mScreen.addPreference(createUserDictionaryPreference(null));
         } else {
             for (String locale : localeSet) {
-                mScreen.addPreference(createUserDictionaryPreference(locale));
+                final Preference pref = createUserDictionaryPreference(locale);
+                if (mScreen.findPreference(pref.getKey()) == null) {
+                    mScreen.addPreference(pref);
+                }
             }
         }
     }