Cppcheck: Class '...' has a constructor with 1 argument that is not explicit.

diff --git a/Src/AboutDlg.cpp b/Src/AboutDlg.cpp
index 6b009fb..2050542 100644 (file)
--- a/Src/AboutDlg.cpp
+++ b/Src/AboutDlg.cpp
@@ -36,7 +36,7 @@
 class CAboutDlg::Impl : public CTrDialog
 {
 public:
-       Impl(CAboutDlg *p, CWnd* pParent = nullptr);
+       explicit Impl(CAboutDlg *p, CWnd* pParent = nullptr);
 
 // Dialog Data
        //{{AFX_DATA(CAboutDlg::Impl)

diff --git a/Src/CompareStatisticsDlg.h b/Src/CompareStatisticsDlg.h
index 22f4e89..7785642 100644 (file)
--- a/Src/CompareStatisticsDlg.h
+++ b/Src/CompareStatisticsDlg.h
@@ -35,7 +35,7 @@ class CompareStatisticsDlg : public CTrDialog
        DECLARE_DYNAMIC(CompareStatisticsDlg)
 
 public:
-       CompareStatisticsDlg(const CompareStats * pStats, CWnd* pParent = nullptr);   // standard constructor
+       explicit CompareStatisticsDlg(const CompareStats * pStats, CWnd* pParent = nullptr);   // standard constructor
 
 // Dialog Data
        //{{AFX_DATA(CompareStatisticsDlg)

diff --git a/Src/DirItemIterator.h b/Src/DirItemIterator.h
index a173eb2..79daf0c 100644 (file)
--- a/Src/DirItemIterator.h
+++ b/Src/DirItemIterator.h
@@ -17,7 +17,7 @@ class DIFFITEM;
 class DirItemWithIndexIterator : public std::iterator<std::forward_iterator_tag, std::pair<int, DIFFITEM *> >
 {
 public:
-       DirItemWithIndexIterator(IListCtrl *pList, int sel = -1, bool selected = false, bool reverse = false) :
+       explicit DirItemWithIndexIterator(IListCtrl *pList, int sel = -1, bool selected = false, bool reverse = false) :
          m_pList(pList), m_sel(sel), m_selected(selected), m_reverse(reverse)
        {
                if (m_sel == -1)
@@ -92,7 +92,7 @@ private:
 class DirItemIterator : public std::iterator<std::forward_iterator_tag, DIFFITEM*>
 {
 public:
-       DirItemIterator(IListCtrl *pList, int sel = -1, bool selected = false, bool reverse = false) : 
+       explicit DirItemIterator(IListCtrl *pList, int sel = -1, bool selected = false, bool reverse = false) : 
          m_pList(pList), m_sel(sel), m_selected(selected), m_reverse(reverse), m_pdi(nullptr)
        {
                if (m_sel == -1)

diff --git a/Src/LoadSaveCodepageDlg.h b/Src/LoadSaveCodepageDlg.h
index 1be4186..56f0a16 100644 (file)
--- a/Src/LoadSaveCodepageDlg.h
+++ b/Src/LoadSaveCodepageDlg.h
@@ -15,7 +15,7 @@ class CLoadSaveCodepageDlg : public CTrDialog
 {
 public:
 // Construction
-       CLoadSaveCodepageDlg(int nFiles, CWnd* pParent = nullptr);   // standard constructor
+       explicit CLoadSaveCodepageDlg(int nFiles, CWnd* pParent = nullptr);   // standard constructor
        void SetLeftRightAffectStrings(const String & sAffectsLeft, const String & sAffectsMiddle, const String & sAffectsRight);
        void EnableSaveCodepage(bool enable) { m_bEnableSaveCodepage = enable; }
        void SetCodepages(int codepage) { m_nLoadCodepage = m_nSaveCodepage = codepage; }

diff --git a/Src/SharedFilterDlg.h b/Src/SharedFilterDlg.h
index d1110a7..1d160f2 100644 (file)
--- a/Src/SharedFilterDlg.h
+++ b/Src/SharedFilterDlg.h
@@ -22,7 +22,7 @@ class CSharedFilterDlg : public CTrDialog
 // Construction
 public:
        enum FilterType : int { SHARED = 0, PRIVATE = 1 };
-       CSharedFilterDlg(FilterType type, CWnd* pParent = nullptr);
+       explicit CSharedFilterDlg(FilterType type, CWnd* pParent = nullptr);
        FilterType GetSelectedFilterType() const { return m_selectedType; }
 
 // Implementation

diff --git a/Src/TrDialogs.h b/Src/TrDialogs.h
index ccaeae5..4bce630 100644 (file)
--- a/Src/TrDialogs.h
+++ b/Src/TrDialogs.h
@@ -40,8 +40,8 @@ class CTrDialog : public CDialog, public DlgUtils<CTrDialog>
        DECLARE_DYNAMIC(CTrDialog)\r
 public:\r
        CTrDialog() : CDialog() {}\r
-       CTrDialog(UINT nIDTemplate, CWnd *pParent = nullptr) : CDialog(nIDTemplate, pParent) {}\r
-       CTrDialog(LPCTSTR lpszTemplateName, CWnd *pParentWnd = nullptr) : CDialog(lpszTemplateName, pParentWnd) {}\r
+       explicit CTrDialog(UINT nIDTemplate, CWnd *pParent = nullptr) : CDialog(nIDTemplate, pParent) {}\r
+       explicit CTrDialog(LPCTSTR lpszTemplateName, CWnd *pParentWnd = nullptr) : CDialog(lpszTemplateName, pParentWnd) {}\r
 \r
        virtual BOOL OnInitDialog();\r
 };\r

diff --git a/Src/WMGotoDlg.cpp b/Src/WMGotoDlg.cpp
index d5e0bae..b673f6a 100644 (file)
--- a/Src/WMGotoDlg.cpp
+++ b/Src/WMGotoDlg.cpp
@@ -39,7 +39,7 @@ class WMGotoDlg::Impl : public CTrDialog
 {
 // Construction
 public:
-       Impl(WMGotoDlg *p, CWnd* pParent = nullptr);   // standard constructor
+       explicit Impl(WMGotoDlg *p, CWnd* pParent = nullptr);   // standard constructor
 
 // Dialog Data
        //{{AFX_DATA(WMGotoDlg)

diff --git a/Src/markdown.h b/Src/markdown.h
index 475dbe6..6fd42d0 100644 (file)
--- a/Src/markdown.h
+++ b/Src/markdown.h
@@ -61,7 +61,7 @@ public:
        };
        int nByteOrder;
        Poco::SharedMemory *m_pSharedMemory;
-       FileImage(const TCHAR *, size_t trunc = 0, unsigned flags = 0);
+       explicit FileImage(const TCHAR *, size_t trunc = 0, unsigned flags = 0);
        FileImage(const FileImage& other) = delete;
        ~FileImage();
        static int GuessByteOrder(unsigned);
@@ -71,7 +71,7 @@ class CMarkdown::File : public CMarkdown::FileImage, public CMarkdown
 {
 //     Construct CMarkdown object from file.
 public:
-       File(const TCHAR * path, size_t trunc = 0, unsigned flags = Octets):
+       explicit File(const TCHAR * path, size_t trunc = 0, unsigned flags = Octets):
        CMarkdown::FileImage(path, trunc, flags),
        CMarkdown((const char *)pImage, (const char *)pImage + cbImage, flags)
        {