OSDN Git Service

staging: vt6655: Fix fall-through warnings for Clang
authorGustavo A. R. Silva <gustavoars@kernel.org>
Fri, 20 Nov 2020 18:27:44 +0000 (12:27 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Nov 2020 16:55:23 +0000 (17:55 +0100)
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of just
letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/863fda60074850bc976974af48fa769c64725e64.1605896059.git.gustavoars@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6655/device_main.c
drivers/staging/vt6655/rxtx.c

index 9c7d70e..9791654 100644 (file)
@@ -1582,6 +1582,7 @@ static int vnt_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        case DISABLE_KEY:
                if (test_bit(key->hw_key_idx, &priv->key_entry_inuse))
                        clear_bit(key->hw_key_idx, &priv->key_entry_inuse);
+               break;
        default:
                break;
        }
index 508e1bd..ff45206 100644 (file)
@@ -1007,6 +1007,7 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
                switch (info->control.hw_key->cipher) {
                case WLAN_CIPHER_SUITE_CCMP:
                        cbMICHDR = sizeof(struct vnt_mic_hdr);
+                       break;
                default:
                        break;
                }
@@ -1321,6 +1322,7 @@ int vnt_generate_fifo_header(struct vnt_private *priv, u32 dma_idx,
                        break;
                case WLAN_CIPHER_SUITE_CCMP:
                        tx_buffer_head->frag_ctl |= cpu_to_le16(FRAGCTL_AES);
+                       break;
                default:
                        break;
                }