OSDN Git Service

[media] cec: CEC_MSG_GIVE_FEATURES should abort for CEC version < 2
authorHans Verkuil <hansverk@cisco.com>
Fri, 9 Dec 2016 13:28:19 +0000 (11:28 -0200)
committerRay Zhang <rayz@codeaurora.org>
Thu, 25 May 2017 03:22:19 +0000 (11:22 +0800)
This is a 2.0 only message, so it should return Feature Abort if the
adapter is configured for CEC version 1.4.

Right now it does nothing, which means that the sender will time out.

Change-Id: I6bdf5e08e075cf071b7f5e0b3996bc111d1f89a7
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Git-commit: a24f56d47930492c94ef6875bf45adf7607ca1a4
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
Signed-off-by: Ray Zhang <rayz@codeaurora.org>
drivers/media/cec/cec-adap.c

index 3191c0c..c05956f 100644 (file)
@@ -1777,9 +1777,9 @@ static int cec_receive_notify(struct cec_adapter *adap, struct cec_msg *msg,
        }
 
        case CEC_MSG_GIVE_FEATURES:
-               if (adap->log_addrs.cec_version >= CEC_OP_CEC_VERSION_2_0)
-                       return cec_report_features(adap, la_idx);
-               return 0;
+               if (adap->log_addrs.cec_version < CEC_OP_CEC_VERSION_2_0)
+                       return cec_feature_abort(adap, msg);
+               return cec_report_features(adap, la_idx);
 
        default:
                /*