OSDN Git Service

spi: orion: fix runtime PM initialization
authortomaspaukrt@email.cz <tomaspaukrt@email.cz>
Wed, 25 Sep 2019 10:08:44 +0000 (12:08 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 26 Sep 2019 15:23:21 +0000 (08:23 -0700)
The current initialisation of runtime PM in the orion-spi.c driver is
incorrect, because calling pm_runtime_put_autosuspend before calling
pm_runtime_get leads to a negative value of the reference count and
therefore it sometimes causes suspend during a transmission.

Signed-off-by: Tomas Paukrt <tomaspaukrt@email.cz>
Link: https://lore.kernel.org/r/E2A.ZWgn.6sH16TohXKE.1TYpoi@seznam.cz
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-orion.c

index 6643ccd..81c991c 100644 (file)
@@ -772,9 +772,6 @@ static int orion_spi_probe(struct platform_device *pdev)
        if (status < 0)
                goto out_rel_pm;
 
-       pm_runtime_mark_last_busy(&pdev->dev);
-       pm_runtime_put_autosuspend(&pdev->dev);
-
        master->dev.of_node = pdev->dev.of_node;
        status = spi_register_master(master);
        if (status < 0)