OSDN Git Service

net: wwan: qcom_bam_dmux: fix wrong pointer passed to IS_ERR()
authorYang Yingliang <yangyingliang@huawei.com>
Sat, 19 Mar 2022 03:24:50 +0000 (11:24 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 22 Mar 2022 08:36:46 +0000 (09:36 +0100)
It should check dmux->tx after calling dma_request_chan().

Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20220319032450.3288224-1-yangyingliang@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/wwan/qcom_bam_dmux.c

index 5dfa2eb..17d46f4 100644 (file)
@@ -755,7 +755,7 @@ static int __maybe_unused bam_dmux_runtime_resume(struct device *dev)
                return 0;
 
        dmux->tx = dma_request_chan(dev, "tx");
-       if (IS_ERR(dmux->rx)) {
+       if (IS_ERR(dmux->tx)) {
                dev_err(dev, "Failed to request TX DMA channel: %pe\n", dmux->tx);
                dmux->tx = NULL;
                bam_dmux_runtime_suspend(dev);