OSDN Git Service

greybus: svc: Print expected/actual payload size on mismatch
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 6 Aug 2015 07:14:54 +0000 (12:44 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Tue, 11 Aug 2015 00:29:27 +0000 (17:29 -0700)
Print (expected-payload-size actual-payload-size), when the size doesn't
match for requests received by the module. This gives more details
required for debugging the issue.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/svc.c

index b89e889..4d59cbb 100644 (file)
@@ -269,7 +269,8 @@ static int gb_svc_intf_hotplug_recv(struct gb_operation *op)
        int ret;
 
        if (request->payload_size < sizeof(*hotplug)) {
-               dev_err(dev, "%s: short hotplug request received\n", __func__);
+               dev_err(dev, "%s: short hotplug request received (%zu < %zu)\n",
+                       __func__, request->payload_size, sizeof(*hotplug));
                return -EINVAL;
        }
 
@@ -372,7 +373,8 @@ static int gb_svc_intf_hot_unplug_recv(struct gb_operation *op)
 
        if (request->payload_size < sizeof(*hot_unplug)) {
                dev_err(&op->connection->dev,
-                       "short hot unplug request received\n");
+                       "short hot unplug request received (%zu < %zu)\n",
+                       request->payload_size, sizeof(*hot_unplug));
                return -EINVAL;
        }
 
@@ -400,7 +402,8 @@ static int gb_svc_intf_reset_recv(struct gb_operation *op)
 
        if (request->payload_size < sizeof(*reset)) {
                dev_err(&op->connection->dev,
-                       "short reset request received\n");
+                       "short reset request received (%zu < %zu)\n",
+                       request->payload_size, sizeof(*reset));
                return -EINVAL;
        }
        reset = request->payload;