OSDN Git Service

f2fs: fix to call put_page at the error handling routine
authorJaegeuk Kim <jaegeuk@kernel.org>
Tue, 18 Nov 2014 00:06:55 +0000 (16:06 -0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 19 Nov 2014 01:02:47 +0000 (17:02 -0800)
The locked page should be released before returning the function.

Reviewed-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/inline.c

index 053d114..f26fb87 100644 (file)
@@ -141,8 +141,8 @@ int f2fs_convert_inline_inode(struct inode *inode)
 
        ipage = get_node_page(sbi, inode->i_ino);
        if (IS_ERR(ipage)) {
-               f2fs_unlock_op(sbi);
-               return PTR_ERR(ipage);
+               err = PTR_ERR(ipage);
+               goto out;
        }
 
        set_new_dnode(&dn, inode, ipage, ipage, 0);
@@ -151,7 +151,7 @@ int f2fs_convert_inline_inode(struct inode *inode)
                err = f2fs_convert_inline_page(&dn, page);
 
        f2fs_put_dnode(&dn);
-
+out:
        f2fs_unlock_op(sbi);
 
        f2fs_put_page(page, 1);