OSDN Git Service

IB/core: Use rdma_is_port_valid()
authorParav Pandit <parav@mellanox.com>
Mon, 19 Mar 2018 05:59:59 +0000 (07:59 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 19 Mar 2018 17:41:40 +0000 (11:41 -0600)
Use rdma_is_port_valid() which performs port validity check instead of
open coding the same check.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/cache.c

index 31def0f..5b9416a 100644 (file)
@@ -937,8 +937,7 @@ int ib_get_cached_subnet_prefix(struct ib_device *device,
        unsigned long flags;
        int p;
 
-       if (port_num < rdma_start_port(device) ||
-           port_num > rdma_end_port(device))
+       if (!rdma_is_port_valid(device, port_num))
                return -EINVAL;
 
        p = port_num - rdma_start_port(device);
@@ -1048,7 +1047,7 @@ int ib_get_cached_port_state(struct ib_device   *device,
        unsigned long flags;
        int ret = 0;
 
-       if (port_num < rdma_start_port(device) || port_num > rdma_end_port(device))
+       if (!rdma_is_port_valid(device, port_num))
                return -EINVAL;
 
        read_lock_irqsave(&device->cache.lock, flags);