OSDN Git Service

ASoC: SOF: Intel: hda-dsp: report error on power-up/down
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 16 Jun 2022 21:53:39 +0000 (16:53 -0500)
committerMark Brown <broonie@kernel.org>
Fri, 17 Jun 2022 09:46:36 +0000 (10:46 +0100)
dev_dbg() is not good-enough since the flow returns an error.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220616215351.135643-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-dsp.c

index 263ad45..2afaee9 100644 (file)
@@ -743,7 +743,7 @@ int hda_dsp_resume(struct snd_sof_dev *sdev)
                        if (hlink->ref_count) {
                                ret = snd_hdac_ext_bus_link_power_up(hlink);
                                if (ret < 0) {
-                                       dev_dbg(sdev->dev,
+                                       dev_err(sdev->dev,
                                                "error %d in %s: failed to power up links",
                                                ret, __func__);
                                        return ret;
@@ -871,7 +871,7 @@ int hda_dsp_suspend(struct snd_sof_dev *sdev, u32 target_state)
                /* no link can be powered in s0ix state */
                ret = snd_hdac_ext_bus_link_power_down_all(bus);
                if (ret < 0) {
-                       dev_dbg(sdev->dev,
+                       dev_err(sdev->dev,
                                "error %d in %s: failed to power down links",
                                ret, __func__);
                        return ret;