OSDN Git Service

jbd2: Drop unnecessary branch from jbd2_journal_forget()
authorJan Kara <jack@suse.cz>
Fri, 9 Aug 2019 12:42:30 +0000 (14:42 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 21 Oct 2019 13:16:46 +0000 (09:16 -0400)
We have cleared both dirty & jbddirty bits from the bh. So there's no
difference between bforget() and brelse(). Thus there's no point jumping
to no_jbd branch.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20190809124233.13277-5-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/transaction.c

index 6201130..2d42bc4 100644 (file)
@@ -1599,10 +1599,6 @@ int jbd2_journal_forget (handle_t *handle, struct buffer_head *bh)
                } else {
                        __jbd2_journal_unfile_buffer(jh);
                        jbd2_journal_put_journal_head(jh);
-                       if (!buffer_jbd(bh)) {
-                               spin_unlock(&journal->j_list_lock);
-                               goto not_jbd;
-                       }
                }
                spin_unlock(&journal->j_list_lock);
        } else if (jh->b_transaction) {