OSDN Git Service
(root)
/
android-x86
/
frameworks-native.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8042c37
)
installd: Avoid extra std::string copy
author
Greg Kaiser
<gkaiser@google.com>
Tue, 26 Mar 2019 15:55:32 +0000
(08:55 -0700)
committer
Greg Kaiser
<gkaiser@google.com>
Tue, 26 Mar 2019 16:28:23 +0000
(09:28 -0700)
The method is_valid_package_name() takes a const std::string
reference, so it's inefficient to pass a std::string::c_str().
Test: TreeHugger
Change-Id: Ic8b33ce8b6c664f960b5c84f688821e9f7eddf03
cmds/installd/InstalldNativeService.cpp
patch
|
blob
|
history
diff --git
a/cmds/installd/InstalldNativeService.cpp
b/cmds/installd/InstalldNativeService.cpp
index
a51946d
..
ae4ea78
100644
(file)
--- a/
cmds/installd/InstalldNativeService.cpp
+++ b/
cmds/installd/InstalldNativeService.cpp
@@
-180,7
+180,7
@@
binder::Status checkArgumentUuidTestOrNull(const std::unique_ptr<std::string>& u
}
binder::Status checkArgumentPackageName(const std::string& packageName) {
- if (is_valid_package_name(packageName
.c_str()
)) {
+ if (is_valid_package_name(packageName)) {
return ok();
} else {
return exception(binder::Status::EX_ILLEGAL_ARGUMENT,