OSDN Git Service

ALSA: lola: Deletion of an unnecessary check before the function call "vfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 17 Nov 2014 11:42:16 +0000 (12:42 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 17 Nov 2014 12:46:23 +0000 (13:46 +0100)
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/lola/lola_mixer.c

index 782f4d8..e7fe15d 100644 (file)
@@ -108,8 +108,7 @@ int lola_init_pins(struct lola *chip, int dir, int *nidp)
 
 void lola_free_mixer(struct lola *chip)
 {
-       if (chip->mixer.array_saved)
-               vfree(chip->mixer.array_saved);
+       vfree(chip->mixer.array_saved);
 }
 
 int lola_init_mixer_widget(struct lola *chip, int nid)