OSDN Git Service

openvswitch: Using kfree_rcu() to simplify the code
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 14 Nov 2017 06:27:12 +0000 (06:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Nov 2017 13:02:08 +0000 (22:02 +0900)
The callback function of call_rcu() just calls a kfree(), so we
can use kfree_rcu() instead of call_rcu() + callback function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/meter.c

index 2e58b6c..52ddd6c 100644 (file)
@@ -42,19 +42,12 @@ static const struct nla_policy band_policy[OVS_BAND_ATTR_MAX + 1] = {
        [OVS_BAND_ATTR_STATS] = { .len = sizeof(struct ovs_flow_stats) },
 };
 
-static void rcu_free_ovs_meter_callback(struct rcu_head *rcu)
-{
-       struct dp_meter *meter = container_of(rcu, struct dp_meter, rcu);
-
-       kfree(meter);
-}
-
 static void ovs_meter_free(struct dp_meter *meter)
 {
        if (!meter)
                return;
 
-       call_rcu(&meter->rcu, rcu_free_ovs_meter_callback);
+       kfree_rcu(meter, rcu);
 }
 
 static struct hlist_head *meter_hash_bucket(const struct datapath *dp,